Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bulgarian language implementation #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Bulgarian language implementation #520

wants to merge 1 commit into from

Conversation

kgizdov
Copy link

@kgizdov kgizdov commented May 4, 2023

Changes proposed in this pull request:

Add Bulgarian language implementation

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

from num2words import num2words

bg_text = num2words(12.56, lang="bg")
bg_text = num2words(12.56, to="currency", lang="bg")

Additional notes

Used daily in our codebase in a private fork. Would like to contribute upstream and clean up our deployment process.

smilingDima
smilingDima reviewed May 5, 2023
View reviewed changes
num2words/lang_BG.py
words.append(self.pluralize(chunk, SCALE[chunk_len]))

return ' '.join(words)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good decision to put boolean feminine parameter, because you have 3 genders - masculine, feminine and neuter. Later it will be a problem with backward compatibility.
Like here.
I suggest adding the gender parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smilingDima smilingDima smilingDima left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgizdov @smilingDima